This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): datepicker-popup compatibility with ngModelOptions #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisirhc
force-pushed
the
feature/datepicker-refactor
branch
from
a8b0eff to
80486ec
Compare
chrisirhc
force-pushed
the
feature/datepicker-refactor
branch
from
80486ec to
c7e20e6
Compare
| if (isNaN(date)) { | ||
| return false; | ||
| } else { | ||
| return true; |
There was a problem hiding this comment.
This can be simplified by just doing return !isNaN(date);
|
Excepting my one comment, this LGTM. |
- Separate validation from parsing so that validation still runs on model change - Remove direct calls to $render - Remove extra call to $render during intialization (only run when format is changed) - Save last date value in formatter - Remove use of ngModel.$modelValue as users may add parsers to convert $modelValue to other formats Relates to angular-ui#2069 Fixes angular-ui#3349
chrisirhc
force-pushed
the
feature/datepicker-refactor
branch
from
c7e20e6 to
d024dd7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3349