This repository has been archived by the owner on May 29, 2019. It is now read-only.
Removed need for empty dropdown attributes. #3460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding "restrict: 'EAC'" to the directives, we no longer need to add the empty dropdown and dropdown-toggle directives. This need for duplicity (both class and attribute) contributes to more clutter in the html.
|
We've removed class restrict intentionally. See #2156 for discussion. The class attribute causes unintentional conflict. It's also too generic as a class. Users may have code that just uses the |
|
Closing this, due to the explicit removal of support as mentioned in the above referenced issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding "restrict: 'EAC'" to the directives, we no longer need to add the empty dropdown and dropdown-toggle directives.
This need for duplicity (both class and attribute) contributes to more clutter in the html.