This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): fix tooltip position if he used in container with non static position #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tooltip position if he used in container with non static position
|
@valorkin Thnx for this pull request, we are really determined to fix those positioning issues :-) But I think that I've bitten you on this one as just yesterday I've opened a pull request with a new positioning service that we are planning to use for tooltips / popovers. The PR is here: From the quick look we are taking the same approach, I've just extracted code to a separate service and don't need to call bounding client rectangle on each element in a hierarchy. Going to close those one for now, would be absolutely, totally awesome if you could review ab0bce4 |
codedogfish
pushed a commit
to codedogfish/angular-ui-bootstrap
that referenced
this pull request
Sep 15, 2015
Tagging support (continues angular-ui#260)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append to body is not suitable for tooltips binded to scope property inside isolated scope.