Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(typeahead): access to $item in typeahead-input-formatter and item resolver #2962

Closed
wants to merge 2 commits into from

Conversation

miiihi
Copy link

@miiihi miiihi commented Nov 13, 2014

This solves problems with input formatting and initialization. IMO it fixes #981, #274...

In short, we add access to $item in formatter, if we have an item, if we don't (ie. on initialization and programaticaly setting value), we use callback for item resolving and rerun formatters, when callback returns.

@smurugavel
Copy link

Hello..
This is a great accomplishment in typeahead for complex data needs. $item suits me well. I was wondering if there are plans to port this code, so it is compatible with angular ui 0.13.3 and angular 1.4?

thanks
Murugavel

@pkozlowski-opensource
Copy link
Member

Well, this "great accomplishment" doesn't merge cleanly any more and doesn't have associated tests. There is no way we can merge such a substantial patch without associated unit tests.

@miiihi see my comment above - if you are still interested in getting this in, please rebase on top of current master, add tests and submit a new PR. Thnx!

@smurugavel
Copy link

I see that as an attempt made and being successful. I agree that this doesn't merge well on latest code but it worked in ui-bootstrap-tpls-0.13.0.js. Yes, I understand the latest version is 0.13.3

@pkozlowski-opensource
Copy link
Member

@smurugavel it is more about lack of unit tests. Once again, we need to have tests to prove that the code does what it claims and avoid regressions in the future.

@miiihi
Copy link
Author

miiihi commented Aug 30, 2015

Well, I'm interested in getting this merged, since we use this in production - but as there was zero response to my pull request I didn't pursue this any further...

Will rebase and prepare unit tests asap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeahead changes input display value with model (array of objects)
4 participants