This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(alert) Rename alert-dismissable to alert-dismissible #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobJacobs what is the Bootstrap version that is needed for this change? Would it still work with BS 3.1.x? |
|
@pkozlowski-opensource Bootstrap 3.1.x still has the alert-dimissable class. This change is in the 3.2 release which has both the alert-dimissable and alert-dismissible classes with the alert-dismissable marked as deprecated. I can understand you not wanting to merge this pull request now but I figured I would create it for future reference. |
|
Yep, this one will have to wait till we move to BS 3.2 (which I think we should do soner that later and it should be a big deal). |
pkozlowski-opensource
added
Bootstrap 3.0
Bootstrap 3.2
and removed
Bootstrap 3.0
labels
|
Landed in d631af5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change coincides with the bootstrap rename change: 13845