Removed unnecessary string replacements #2635
Conversation
|
This looks like a documentation change and should be under docs commit type. |
If `.html` is removed from the end only to be added to the end, there's no reason to touch it. Also, `template` + `/` is the same as `template/`. I haven't tested this, but I see absolutely no reason why this code isn't the same functionally.
|
That should be unnecessary. This was a commit filed through the GitHub interface; it's a massive barrier to entry if people can't use the GitHub inline editor. You can tell it is a GitHub-originating fix by the branch name. Cf. third paragraph of the guidelines. |
RichardLitt
force-pushed
the
patch-1
branch
from
9851d68 to
5d1848d
Compare
|
*can't use it as is, without reading the contributing guidelines to figure out how to style a commit message. Just sayin'. |
|
I see, I didn't realize that the fix was from Github's inline editor. I'll be sure to check that next time. Changing the commit message first before merging it into master isn't a whole lot of work for me, I just wanted to communicate the convention to contributors. |
|
No worries. The docs about contribution on this point aren't in fact clear. I'll add something about that for now, this whole process should be easier. |
It's important that we let people use the GitHub editing interface without being 100% strict about how to name the commit changes. Otherwise, it is basically a barrier to entry and highly discouraging for new people who may just be trying to fix a spelling error. Since it is possible for contributors to edit the commit message before merging it into master, for people who are new to the commit styling system, we should be lenient about minor infractions like forgetting to put docs: in front of a message. CF: angular-ui/bootstrap#2635 (comment)
|
Thank you! |
|
👍 |
If `.html` is removed from the end only to be added to the end, there's no reason to touch it. Also, `template` + `/` is the same as `template/`. I haven't tested this, but I see absolutely no reason why this code isn't the same functionally. Closes angular-ui#2635
If `.html` is removed from the end only to be added to the end, there's no reason to touch it. Also, `template` + `/` is the same as `template/`. I haven't tested this, but I see absolutely no reason why this code isn't the same functionally. Closes angular-ui#2635
If
.htmlis removed from the end only to be added to the end, there's no reason to touch it. Also,template+/is the same astemplate/.I haven't tested this, but I see absolutely no reason why this code isn't the same functionally.