This repository has been archived by the owner on May 29, 2019. It is now read-only.
Fixes #2293. #2535
Closed
Fixes #2293. #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed fixed with 1.3.0-beta.17.
This was referenced Aug 1, 2014
|
What are the chances, that this PR is merged? |
|
@kkragenbrink - Any news on whether or not the Travis build can be fixed so this PR can be merged? I've confirmed that the fix works (manually making the change myself in a local copy of the plugin), but admittedly I don't know enough about the test suite or the plugin to feel confident about getting it to run green. |
|
I've never used Travis CI before, nor this test harness, but I will try and figure it out this weekend and get it cleaned up. |
|
any change this can get merged in? |
|
@davisford This won't get merged as it doesn't pass the build tests, but #2557 does. |
|
+1 |
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Fixes angular-ui#2474 Fixes angular-ui#2541 Fixes angular-ui#2293 Closes angular-ui#2535 Closes angular-ui#2557
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed fixed with 1.3.0-beta.17.