This repository has been archived by the owner on May 29, 2019. It is now read-only.
Add tooltips to body to avoid css adjacency issues #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, tooltip markup is added `after` the element on which the directive is defined. As a result, any adjacency selectors based on the element having a controlled set of siblings will be affected. This change will add the tooltip element as a child of the body instead.
|
Thanks for this! We've been discussing doing something similar in #139 but were waiting on a major refactor of the tooltip, which landed on Sunday but has yet to be merged (PR #210). We are also not sure which approach to take; do you want to hop on over to #139 and give your opinion? Also, the build failed because we're currently migrating to Grunt 0.4, so don't worry about that. |
|
I just opened a PR for this solution, but as an optional feature, in #254, so I'll go ahead and close this one. Thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tooltip markup is added
afterthe element on which thedirective is defined. As a result, any adjacency selectors based on
the element having a controlled set of siblings will be affected.
This change will add the tooltip element as a child of the body instead.