Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Update typeahead to fix #1773 #1793

Closed
wants to merge 3 commits into from
Closed

Update typeahead to fix #1773 #1793

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acf423a
Update typeahead to fix #1773
shayanelhami Feb 12, 2014
caeac33
Fix #1773 by calling focus in a $timeout
shayanelhami Feb 18, 2014
99febb1
typeahead: fix #1773 with $timeout
shayanelhami Feb 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/typeahead/typeahead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap
resetMatches();

//return focus to the input element if a mach was selected via a mouse click event
element[0].focus();
// use timeout to avoid $rootScope:inprog error
$timeout(function() { element[0].focus(); }, 1, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does $timeout(function() { element[0].focus(); }, 0, false); work? Was there a reason for picking the values 1 and true (invokeApply = true)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and it does work with 0 and false (see http://plnkr.co/FimbQhGviK5dDVarLaRy). I'll give you another commit.

};

//bind keyboard events: arrows up(38) / down(40), enter(13) and tab(9), esc(27)
Expand Down Expand Up @@ -346,4 +347,4 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap
return function(matchItem, query) {
return query ? ('' + matchItem).replace(new RegExp(escapeRegexp(query), 'gi'), '<strong>$&</strong>') : matchItem;
};
});
});