feat(typeahead): handles min-length of 0 #1624
Conversation
ghost
assigned 
|
This is some good work. @chrisirhc are you still planning in integrating this (since the PR you mentioned is closed)? Otherwise I would vote to add this in a 0.13.x release -- can imagine people would use this. In the meanwhile, @zacronos can you update the PR so we can merge it with the current master? |
|
@rvanbaalen, sure, I'll take a look and see what it takes to get it in line with master. |
|
Awesome. Much appreciated. This email was sent from my iPhone and therefore subject to typos and other inaccuracies.
|
|
@rvanbaalen, I apologize, but I've never gotten the hang of rebasing and whatnot in order to keep updated PRs from showing a huge list of modified files that aren't really modified. So to keep things clean and straightforward, I've just opened a new PR with the updates: #3600 |
|
No problem. You closed the old one and referenced the new one. Perfect. |
| expect(element).toBeOpenWithActive(3, 0); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should it not also check if the input is focus'd?
Otherwise any typeahead directive would stay open?
|
@dmitriz, please comment on the new PR for this feature instead of this one (this PR is closed): https://github.com/angular-ui/bootstrap/pull/3600/files Though the new PR is identical in terms of functionality, I did write a few lines differently for readability. |
|
sorry - left tabs open overnight and didn't notice it was closed - my bad! :) |
Correctly handles min-length of 0 (i.e. will keep typeahead popup open even when all input has been deleted).