This repository has been archived by the owner on May 29, 2019. It is now read-only.
(WIP) chore(tests): use bower for test lib dependencies #1542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge!
Update: I played around with switching version numbers and it looks like the version resolution on Bower is... incomplete. After switching the version number, one still has to go through some prompts in order to get the correct AngularJS version installed. I've opened an issue on bower/bower#1037.
Consider the
npm install
commit but for now I don't think we should use bower.Also in this PR, run
npm install
on grunt configuration. I saw this on AngularJS and I think that's how they keep the packages Jenkins up-to-date. I'm thinking it's not that harmful but we can discuss if that shouldn't be in this PR.Related to package discussion in #1503.