This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(interval): Use $interval instead of $timeout for Angular 1.2.x #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only problem I have is that all tests fail, maybe someone can take a look at it? It seems that Angular isn't loading properly or something like that. |
|
Relates to #1308 . Thank you for the pull request. It looks like this is creating a new interval timer every time and doesn't really benefit from the switchover from the $timeout service. |
|
That's correct @chrisirhc, I saw your work in #1342, so I'll wait for that before I move on to updating things. I will close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the carousel to use the $interval instead of $timeout.