You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
I think I've identified the cause of a memory leak in my company's app. The tooltip directive registers a keypress listener on an event, and does not remove it.
This creates a jquery cache entry, which retains the scope through the context.
For all the other listeners registered in prepTriggers(), they are deregistered in unregisterListeners(). Seems to me that the keypress listener should get deregistered too.
Before I go through the trouble of creating a plunkr, would you agree that the leak is obvious enough? The fix would be to make the keypress listener function into a named function, and deregister it at the end of the unregisterListeners function.
Thanks
The text was updated successfully, but these errors were encountered:
I think I've identified the cause of a memory leak in my company's app. The tooltip directive registers a keypress listener on an event, and does not remove it.
bootstrap/src/tooltip/tooltip.js
Lines 547 to 551 in 7855976
This creates a jquery cache entry, which retains the scope through the context.
For all the other listeners registered in
prepTriggers()
, they are deregistered inunregisterListeners()
. Seems to me that the keypress listener should get deregistered too.Before I go through the trouble of creating a plunkr, would you agree that the leak is obvious enough? The fix would be to make the keypress listener function into a named function, and deregister it at the end of the unregisterListeners function.
Thanks
The text was updated successfully, but these errors were encountered: