This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): switch to $animate #5585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to adding backdrop with $animate.addClass due to $animateCss issues when animation is disabled
|
This LGTM |
|
Could this help #5314 ? |
|
Possibly - if you'd like, feel free to investigate. It shouldn't take much work to verify if the usage of $animateCss is the case. |
|
Re: #5314 I tried and got completely lost. I haven't really used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues when animation is disabled
Plunker for fix here.
This fixes #5298.