-
Notifications
You must be signed in to change notification settings - Fork 6.7k
bug(modal) ngClass noticeably slow on modal open #5314
Comments
It is evident in 1.0.x (albeit with other noise). I believe it is more linked to the |
We recently upgraded to 1.x from 0.14.x and are noticing a similar effect both on 1.1.0 and 1.0.3. We use the |
@kirkchris I'll feel like you are describing what is documented in #5298 Regardless if you could provide a plnkr with your workaround I would be interested. |
@sime hmm, it's very possible the two are related, yes. I'll see if I can put something together, but my workaround wasn't really perfect. We ended up rolling back to 0.14 because even with the semi-fix it there was still a noticeable blink compared to 0.14. |
I think this can be closed now? Could someone else confirm that this commit solves the above mentioned behaviour: I have a demo with 2.0.1, and I do not see the flash of red. |
I have a simple modal template that determines the CSS class of an element based on an hard coded controller value (version 1.1.0): http://plnkr.co/edit/tsNB1FbRryju9UFbtpLc?p=preview
The modal should show an element with a green background, but on initial load, the default state of red is visible for a brief moment on both desktop and mobile browsers.
This problem is not evident in v0.14.3: http://plnkr.co/edit/dA2ZjX3U9t1uummXV25t?p=preview
The text was updated successfully, but these errors were encountered: