This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(tab): add select expressions #5438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests? :P |
|
I tried adding some tests, but it actually ended up locking up Karma - I think I might have to get clever about how to check the select/deselect arguments ( |
wesleycho
force-pushed
the
feat/select-expr
branch
2 times, most recently
from
db06631 to
d340b41
Compare
|
I'm not sure this is testable - having circular reference issues since an object containing a $scope is passed into one of the arguments, jasmine seems to handle this poorly. |
wesleycho
force-pushed
the
feat/select-expr
branch
from
d340b41 to
883a809
Compare
|
Removed $tab expression support, left as just $event support. |
|
Do we want a test for this? If not, LGTM. |
wesleycho
force-pushed
the
feat/select-expr
branch
from
883a809 to
cd3753b
Compare
- Add support for event and tab being available in select/deselect callbacks
wesleycho
force-pushed
the
feat/select-expr
branch
from
cd3753b to
6d0d5d2
Compare
|
Updated with expectations! |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callbacks
This implements the third task of #4836.