$uibTooltip creates massive memory leak

[maxklenk]

Each usage of <span uib-tooltip="Hey"></span> creates a memory leak on each state change with ui-router.

When profiling the heap allocation of this plnkr memory leaks can be seen with tooltips:

and less when there are no tooltips

[Foxandxss]

@maxklenk Could you please check if that happens with the old non-prefixed version? And if possible with 0.13.4?

Thank you.

[maxklenk]

Sure:

0.14.1 uib-tooltip => memory leak
0.14.1 tooltip => memory leak
0.14.0 uib-tooltip => memory leak
0.14.0 tooltip => memory leak
0.13.4 tooltip => no memory leak

[Foxandxss]

Interesting, really interesting. I wonder if we introduced it with the prefix work. It is too much ask for 0.14.0 test?

[Foxandxss]

We did lot of tooltip changes in 0.14.0 so one of them is.

Thoughts @wesleycho ?

[maxklenk]

The memory leak was already introduces in the 0.14.0 release.

[Foxandxss]

Thanks, it is time to check out why and fix it 👍

[wesleycho]

I suspect this might be the cause: c08509a

[wesleycho]

If that is indeed the cause, the fix should be simple - on the $scope $destroy event, just clear out the tooltip from the stackedMap.

[RobJacobs]

@wesleycho Verified that does in fact fix the problem. I can fix this as part of PR #4597 if you would like?

[wesleycho]

Separate PR if possible

[Foxandxss]

Yeah, separate always.

[maxklenk]

Thank you for fixing this that fast!