Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

passing $event to close() brakes the close callback in controllerAs syntax #4386

Closed
ymkins opened this issue Sep 9, 2015 · 0 comments
Closed

passing $event to close() brakes the close callback in controllerAs syntax #4386

ymkins opened this issue Sep 9, 2015 · 0 comments
Labels
component: alert type: bug
Milestone
0.14.0 (Bootstrap...

Comments

@ymkins
Copy link

ymkins commented Sep 9, 2015

AngularJS 1.4.5
ui-bootstrap > 0.13.0

http://plnkr.co/edit/5UIOVj3sDYIyUoNScql9

Since ui-bootstrap 0.13.1 there is 44e06425
It brakes the close callback in controllerAs syntax.

Actually, it's superseded by "feat(alert): add templateUrl support" 88a885ca, since ui-bootstrap 0.13.3.
So, passing $event to close() can be done with custom template without affecting controllerAs syntax.
ymkins referenced this issue Sep 9, 2015
@wesleycho
feat(alert): pass $event to close()
44e0642 
Add ability to hook into `$event` in close callback

Closes #3828
Fixes #3827
@wesleycho wesleycho added this to the 0.14.0 (Bootstrap 3.3) milestone Sep 9, 2015
@wesleycho wesleycho mentioned this issue Sep 9, 2015
Closed
jasonaden pushed a commit to deskfed/bootstrap that referenced this issue Jan 8, 2016
@wesleycho @jasonaden
fix(alert): properly pass $event as local
29f79ff 
- Change to pass object due to how `&` binding works

Fixes angular-ui#4386
Closes angular-ui#4387
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: alert type: bug
Projects
None yet
Milestone
0.14.0 (Bootstrap 3.3)
Development

Successfully merging a pull request may close this issue.

fix(alert): properly pass $event as local wesleycho/bootstrap
2 participants
@wesleycho @ymkins