Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

DatePeeker weeks #3307

Closed
Adhara3 opened this issue Feb 18, 2015 · 3 comments
Closed

DatePeeker weeks #3307

Adhara3 opened this issue Feb 18, 2015 · 3 comments
Labels
component: datepicker type: bug
Milestone
0.13.0 (AngularJS...

Comments

@Adhara3
Copy link

Adhara3 commented Feb 18, 2015

Dear all,

there are a couple of issues here:

  • Week number doeas not reset with January. You can easily see this in the official Plunker. In january 2015 week number reaches 57
  • show-weeks does not work in popup. Probably this is not a bug, but a nice to have instead.

Thanks
Andrea
yanivefraim added a commit to yanivefraim/bootstrap that referenced this issue Feb 21, 2015
@yanivefraim
fixes angular-ui#3307 - DatePeeker weeks - wrong date sent to "getISO…
ca12a32 
…8601WeekNumber" method.

Should be the last week's day, and not the first (otherwise on start of a new year it will send a date of one of last year's days, and will get end of last year's weeks)
yanivefraim added a commit to yanivefraim/bootstrap that referenced this issue Feb 21, 2015
@yanivefraim
Issue angular-ui#3307 fix tests
6c8a657
@yanivefraim yanivefraim mentioned this issue Feb 21, 2015
Closed
yanivefraim added a commit to yanivefraim/bootstrap that referenced this issue Mar 4, 2015
@yanivefraim
fix(datepicker): issue angular-ui#3307 week numbers start over at end…
baf7987 
… of year
yanivefraim added a commit to yanivefraim/bootstrap that referenced this issue Mar 4, 2015
@yanivefraim
fix(datepicker): issue angular-ui#3307 remove trailing whitespace
8ebea8c
@chrisirhc
Copy link
Contributor

#2306 resolves this but hasn't been merged yet. Linking here for reference.

The issue with show-weeks has been fixed on master.

@chrisirhc chrisirhc added this to the 0.13.0 milestone Apr 13, 2015
@karianna karianna removed the PRs plz! label Apr 14, 2015
@wesleycho
Copy link
Contributor

Closing, as #2306 is now in.

@Adhara3
Copy link
Author

Adhara3 commented May 12, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: datepicker type: bug
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

No branches or pull requests
4 participants
@chrisirhc @karianna @wesleycho @Adhara3