fix(datepicker): week count issues #2306
Conversation
|
I also changed the test |
|
I believe it is still relevant - do not have a lot of time at the moment to dive into it again - just fixed a left ddescribe in the spec file, though and merged master into the branch - happy to help, if there are any questions, though. |
|
Thanks for double checking! We'll be pulling in PRs soon and this one looks pretty good. Hold on tight! This email was sent from my iPhone and therefore subject to typos and other inaccuracies.
|
|
Removed my previous wrong comment as I understand the problem better now. |
| }); | ||
|
|
||
| describe('first week in january', function() { | ||
| beforeEach(inject(function() { |
There was a problem hiding this comment.
This empty beforeEach can be removed
|
Good work here. Left some comments above. Needs rebasing though. |
|
Great stuff, thanks! |
|
I think we should try to get this in if there are no other issues other than stylistic issues - we can do the refactoring necessary when merging this in. The history needs to be fixed though. |
|
Merged. Thank you! |
This fixes a few issues with week counting
(1) Week counts in January are counted as last years' weeks when the first Thursday is from last year (e.g., 53, 54, 55, ...). See January 2010, for example.
(2) Week counts in December continue counting the last week(s), which may be part of next year, as weeks from the current year. See December 2014, for example.
(3) Week counting changes depending on the start day. The week containing June 7th 2014 is week 22 with the default start day (Sunday), but week 23 with start day Monday. See examples on http://angular-ui.github.io/bootstrap/ (popup has start day Monday)
The code has been changed so that the Thursday of the week always determines, which week count the week gets assigned, regardless of the start day of the week.