This repository was archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
tabset type attribute requires extra quotes #1409
Comments
I agree, and I think that this is a change that we must consider for the whole library in order to keep things consistent. @jonnypolite Can you investigate similar changes that need to be made in other directives also? Also a PR for this would be very helpful :-) |
Alert is another example of a directive where we could change type to be passed as @ instead of =. |
bekos
added a commit
to bekos/bootstrap
that referenced
this issue
Dec 24, 2013
Closes angular-ui#1409 BREAKING CHANGE: Use interpolation for type attribute. Before: <tabset type="'pills'" ...></tabset > or <tabset type="navtype" ...></tabset> After: <tabset type="pills" ...></tabset> or <tabset type="{{navtype}}" ...></tabset>
bekos
added a commit
to bekos/bootstrap
that referenced
this issue
Jan 8, 2014
Closes angular-ui#1409 BREAKING CHANGE: Use interpolation for type attribute. Before: <tabset type="'pills'" ...></tabset > or <tabset type="navtype" ...></tabset> After: <tabset type="pills" ...></tabset> or <tabset type="{{navtype}}" ...></tabset>
bekos
added a commit
to bekos/bootstrap
that referenced
this issue
Jan 20, 2014
Closes angular-ui#1409 BREAKING CHANGE: Use interpolation for type attribute. Before: <tabset type="'pills'" ...></tabset > or <tabset type="navtype" ...></tabset> After: <tabset type="pills" ...></tabset> or <tabset type="{{navtype}}" ...></tabset>
bekos
added a commit
that referenced
this issue
Jan 20, 2014
Closes #1409 BREAKING CHANGE: Use interpolation for type attribute. Before: <tabset type="'pills'" ...></tabset > or <tabset type="navtype" ...></tabset> After: <tabset type="pills" ...></tabset> or <tabset type="{{navtype}}" ...></tabset>
bekos
added a commit
that referenced
this issue
Jan 21, 2014
Closes #1409 BREAKING CHANGE: Use interpolation for type attribute. Before: <tabset type="'pills'" ...></tabset > or <tabset type="navtype" ...></tabset> After: <tabset type="pills" ...></tabset> or <tabset type="{{navtype}}" ...></tabset>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When declaring a tabset, the type attribute will not function unless it is passed a variable.
For example:
Will function correctly, but this is not intuitive to the user. This happens because the attribute value is passed to scope.$parent.$eval(), which will return undefined if used in the manner documented below:
The text was updated successfully, but these errors were encountered: