fix(dropdown): do not close on right click

- Do not close the dropdown on right click when open due to Firefox's behavior Closes #5052 Fixes #5051
angular-ui · Dec 14, 2015 · bf1768e · bf1768e
1 parent 2a1aaf2
commit bf1768e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/dropdown/dropdown.js b/src/dropdown/dropdown.js
@@ -36,6 +36,8 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])
 
     if (evt && openScope.getAutoClose() === 'disabled') { return; }
 
+    if (evt && evt.which === 3) { return; }
+
     var toggleElement = openScope.getToggleElement();
     if (evt && toggleElement && toggleElement[0].contains(evt.target)) {
       return;

diff --git a/src/dropdown/test/dropdown.spec.js b/src/dropdown/test/dropdown.spec.js
@@ -79,6 +79,15 @@ describe('uib-dropdown', function() {
       expect(element).toHaveClass(dropdownConfig.openClass);
     });
 
+    it('should not close on right click', function() {
+      clickDropdownToggle();
+      element.find('ul a').trigger({
+        type: 'mousedown',
+        which: 3
+      });
+      expect(element).toHaveClass(dropdownConfig.openClass);
+    });
+
     it('should close on $location change', function() {
       clickDropdownToggle();
       expect(element).toHaveClass(dropdownConfig.openClass);