Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng add leads to error with Angular 13 #138

Closed
fmalcher opened this issue Nov 5, 2021 · 1 comment · Fixed by #139 or angular-schule/ngx-deploy-starter#30
Closed

ng add leads to error with Angular 13 #138

fmalcher opened this issue Nov 5, 2021 · 1 comment · Fixed by #139 or angular-schule/ngx-deploy-starter#30
Labels
bug

Comments

@fmalcher
Copy link
Member

fmalcher commented Nov 5, 2021 

$ ng add [email protected]
Could not parse angular.json: Cannot read property 'Loose' of undefined

The reason is this line: https://github.com/angular-schule/angular-cli-ghpages/blob/master/src/ng-add.ts#L21

The JSON parser is deprecated. See https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/core/src/json/parser.ts#L926
@fmalcher fmalcher mentioned this issue Nov 5, 2021
Merged
@fmalcher fmalcher added the bug label Nov 7, 2021
JohannesHoppe added a commit that referenced this issue Nov 19, 2021
@fmalcher @JohannesHoppe
feat: add support for Angular v13 by @fmalcher (v1.0.0-rc.3)
aa7ea02 
* fix: remove deprecated JSON parser, use workspace tools
* v1.0.0-rc.3

fixes #138
fixes #137

Co-authored-by: Johannes Hoppe <[email protected]>
@JohannesHoppe
Copy link
Member

I just published [email protected] to npm! This version supports Angular 13.
Many thanks for the patch!

@JohannesHoppe JohannesHoppe mentioned this issue Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@JohannesHoppe @fmalcher