-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom id selector in dataservice entities #69
feat: add support for custom id selector in dataservice entities #69
Conversation
I dont know why my PR has 9 file changed ? I only change one file and create one under libs directory?? |
@alcaidio, thanks but can you please add .nx/workspace-data to .gitignore? |
fb68539
to
8dbf3e1
Compare
Hey @alcaidio, thanks also for the other PR, but I suggest we make sure that this one gets merged first before continuing. So you still have the nx/workspace in the PR and the package-lock.json. Both shouldn't be there. Can you please fix that? Btw, thanks for that unit test. It was urgently needed... |
e9ff269
to
9041b4e
Compare
I've updated my PR @rainerhahnekamp , thanks for your work :) |
Thanks. It is not on purpose that withPagination is missing in the docs :) |
Hey @alcaidio, sorry to bother you again:
|
9041b4e
to
ce54c9e
Compare
introduced a mechanism to specify a custom id selector for entities in the dataservice. when an entity does not have a default identifier named 'id', the custom selector will be used. the custom id selector must return either a string or a number. enhances flexibility for handling entities with non-standard identifiers in the dataservice.
ce54c9e
to
2a46305
Compare
I don't know how to solve the problem, I've updated my branch and I can't get the tests to work :/ sorry, it's too complicated for me, I'll come back to it if I have time. thanks anyway. |
Introduced a mechanism to specify a custom id selector for entities in the dataservice. (like for ngrx entities)
When an entity does not have a default identifier named 'id', the custom selector can be used.
The custom id selector must return either a string or a number. enhances flexibility for handling entities with non-standard identifiers in the dataservice.