Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selective outline enablement per file #427

Closed
angelozerr opened this issue Jun 11, 2019 · 4 comments
Closed

Add support for selective outline enablement per file #427

angelozerr opened this issue Jun 11, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request performance This issue or enhancement is related to performance concerns symbols
Milestone

Comments

@angelozerr
Copy link
Contributor

Today we can enable/disable the symbol provider with the xml.symbols.enabled preference on client side (very helpful for big file because vscode outline is very slow with big symbols).

But when you disable the symbol provider with this preference, all XML files even when there are little doesn't display the content of the outline. It's really shame.

To fix this problem, we could add a new preferences like xml.symbols.disabled.patterns which is an array of pattern file used to disable symbols if XML file match the pattern. To manage matching of pattern file, we could refactor the xml file association class https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/settings/XMLFileAssociation.java to an new class like FilePatternMatching class and XMLFileAssociation could extend it and new file like XMLSymbolsPatterns could extend it.

@NikolasKomonen
Copy link
Contributor

I can work on this issue if no one else wants to do it.

@NikolasKomonen
Copy link
Contributor

@fbricon @angelozerr Thoughts on using the name xml.symbols.excluded ?

@NikolasKomonen NikolasKomonen added this to the v0.8.0 milestone Jun 11, 2019
@fbricon
Copy link
Contributor

fbricon commented Jun 12, 2019

@fbricon @angelozerr Thoughts on using the name xml.symbols.excluded ?

+1

@angelozerr
Copy link
Contributor Author

Fixed with #432

@angelozerr angelozerr added enhancement New feature or request performance This issue or enhancement is related to performance concerns symbols labels Jul 23, 2019
@angelozerr angelozerr changed the title Support selective enablement of outline per file Add support for selective outline enablement per file Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance This issue or enhancement is related to performance concerns symbols
Projects
None yet
Development

No branches or pull requests

3 participants