-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark element coming from XML Schema/DTD for completion #210
Comments
Will definitely reduce (my 😄) confusion. |
On second thought: it would be even better if copy siblings that are also described in XML Schema or DTD are removed from the list, showing only one entry for equally named elements. |
copy siblings should not done when XML is linked to a grammar. It works like this today when you define a xs:schemaLocation or xsi:noNamespaceShchemaLocation. In your case you have not that, because it uses XML Catalog. It's a bug that I must fix (XMLDocument#hasGrammar should test too grammar coming from XML Catalog). I must fix this bug. |
Would be even better if the name of the originating schema was used instead of the generic "XML Schema" label |
@NikolasKomonen a quick idea that I had to display the XML Schema / DTD URI is to store the key in the content model document https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/model/ContentModelManager.java#L117 and after you can use it to display it in the CMLEementDeclaration. Don't hesitate to ping me if you need more information. |
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
the file name of the schema they come from. Fixes #210 Signed-off-by: Nikolas Komonen <[email protected]>
Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
Fixes #210 Signed-off-by: Nikolas Komonen <[email protected]>
Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
While studying bug with duplicate elements redhat-developer/vscode-xml#78 (comment) I find it should be good to mark the completion elements origin (from XML Schema, from DTD, copy sibling)
A quick idea is to add - XML Schema:
@fbricon @NikolasKomonen @ralfhandl what do you think about that?
The text was updated successfully, but these errors were encountered: