Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(canary): implement canary update checker + small ci change #360

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Preloading
Copy link
Contributor

This makes the check for updates function compatible with canary builds, thru the github actions API. Also fixes a small thing that was bugging me with actions.

Also does some misc. changes to how Geckium checks release updates.

@Preloading
Copy link
Contributor Author

probably fixed the merge conflict. let me know if something went wrong with it

@angelbruni
Copy link
Owner

Actually, maybe it's better if the updater gets reworked first..... hm...............

@dominichayesferen
Copy link
Collaborator

dominichayesferen commented Nov 21, 2024

In the relatively unused Updater module, there is hints of being able to update between different Geckium branches, so considering Canary is a branch of its own because'a you, it may be wise to scrap this and take what you did, work with bruni, and rework the existing updater mechanism to allow the following, using your work here:

  • Branch switching via Geckium Settings...?
  • Updating the very placeholdery way depending on the currently selected branch (falling back to the one in version.json if not manually overridden, ig)

@Preloading
Copy link
Contributor Author

Canary is a branch of its own

Canary isn't really a branch of it's own. In the future, Canary can be used to build separate branches (and possibly PRs for testing them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants