Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pt-BR #348

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Update pt-BR #348

merged 6 commits into from
Nov 19, 2024

Conversation

SoftwareType
Copy link
Contributor

First, I'm gonna warn you that it's, by now, organized just like this Geckium Canary version, so it is not quite up-to-date with the source code (that removes the over-exaggerated spaces). In case that's not fine, I'll be able to standardize

image
image

@SoftwareType SoftwareType marked this pull request as ready for review November 18, 2024 21:57
@angelbruni
Copy link
Owner

angelbruni commented Nov 18, 2024

I have just copy pasted from the file in my real computer, so I have no idea why it is conflicting

Looking at the "Files Changed" tab, it seems that your file is from before the indentation change from yesterday.
I also had to remove periods at the end of description strings (since Material Design didn't do that either).

Small nitpicks that were bothering me a lot in all localisation files of all languages.

@SoftwareType
Copy link
Contributor Author

Oh, makes sense

Gonna fix it later on as I'm gonna be away from the computer for 10 minutes

@angelbruni
Copy link
Owner

Alrighty

@SoftwareType
Copy link
Contributor Author

I tried the new code in the Canary update and it appears an error; just checked that ' was used instead of " in one of the titles

Other than that, I have no idea what this means. I suppose but is it actually supposed to happen?
image

@angelbruni
Copy link
Owner

angelbruni commented Nov 18, 2024

The file currently in the repo seems to work fine (ignore Geckium version):
image

I'd say use the one in the repo and translate that one instead.
Otherwise... it's probably something that is outdated in your end, but you'd have to check line by line.

@angelbruni
Copy link
Owner

Either way, the file in Canary is also already outdated by now.

@SoftwareType
Copy link
Contributor Author

SoftwareType commented Nov 18, 2024

I think the problem is really about the Canary build being outdated. After building the latest version (or smth) I have updated the language then built again after an error from eb7af7d (for some reason). I have no idea what it changed between the other, but it seems to work now

@angelbruni angelbruni merged commit a7ebdf2 into angelbruni:main Nov 19, 2024
@angelbruni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants