Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smol fixes batch 1 #328

Merged
merged 13 commits into from
Nov 16, 2024
Merged

Smol fixes batch 1 #328

merged 13 commits into from
Nov 16, 2024

Conversation

Kiki79250CoC
Copy link
Contributor

@Kiki79250CoC Kiki79250CoC commented Nov 14, 2024

This is a mini-collection of small fixes I've done, in an attempt to correct some issues that happens with Geckium.

I want to note that I did the tests in a rustic way, as I "simulated" the compiler myself (yes) to see if it works. In my tests it does, but I'm probably sure it isn't.

1. Fix Dropdown menus

Commits 7d7d8f5, 65fe941

This attempts to fix the dropdown lists text color on selected items, and the arrow as well
This fix is probably not done the best way, but at least it seems to work.

Before After
beforedropdown afterdropdown

2. Fix the "No update available" text on Add-ons page

Commits 7feda0a, 9a3f721

It just moves the text to not be covered by the search box.

Before After
beforenoupdate afternoupdate

3. Fix the search box placeholder text not being cutted out properly

Commits 2f91636, c8104d4

A very hacky way to force the input to breaks the text by doing ellipsis instead of directly cut it.

Before After
beforesearch aftersearch

4. Fix Chrome 17 About box having Chrome 21's size

Commit 045321b

This seems to be a missing change from the addition of Chrome 17 to Geckium

Before After
BeforeCh17 AfterCh17

Some fixes are probably needed, as I tested it using weird and painful methods.
I put them as a draft but despite the "No update" text fix that is solid, the others are... ehm... more tinkering that a proper fix?

@Kiki79250CoC
Copy link
Contributor Author

Verifications needed to check fusionability of this artisanal-tested ("compiled" by hand with Notepad++) PR.

(Oui. I'm a compiler. A human-architecture-based compiler.)

@Kiki79250CoC Kiki79250CoC marked this pull request as ready for review November 16, 2024 00:16
@angelbruni
Copy link
Owner

I will check this tomorrow, thanks :O

@Kiki79250CoC
Copy link
Contributor Author

Yeah I see, my choice was about the fact it must apply on the root of the CSS, so as it wasn't specific to any version, I though it was more appropriate to specify version as 0 to mean "not version-specific".

Nevertheless I changed that to chrome-1.

@angelbruni angelbruni merged commit 8dfc576 into angelbruni:main Nov 16, 2024
@angelbruni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants