Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to make ru translation #216

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

KonaloboStudio
Copy link
Contributor

No description provided.

@angelbruni
Copy link
Owner

Good morning!
Would you mind telling me if the translations for Chromium strings are straight from Chromium or if they are your own translations? As for Geckium related ones such as GeckiumMaterial, Geckium Wizard and Geckium Settings, they seem to be fine :)

@KonaloboStudio
Copy link
Contributor Author

Some lines (for example, the "about chrome" window) were taken from real chromium. Well, somewhere I had to think of it myself

@angelbruni
Copy link
Owner

I am worried if it's not authentic enough, but something is still better than nothing, and I hope it gives incentive for someone to make it accurate to actual Chromium string.
Or are you wanting to do it? Otherwise I will probably merge this.

@KonaloboStudio
Copy link
Contributor Author

That's probably all I wanted to do for now.

@angelbruni
Copy link
Owner

Alright, thank you.
I will review this later and merge if possible.

@angelbruni angelbruni merged commit 82ac821 into angelbruni:main Oct 22, 2024
@angelbruni
Copy link
Owner

By the way, I realised you forgot to change the customizeAndControlGoogleChrome string now D:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants