Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable choose agent/worker socket type per partition #203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jfonseca-aneo
Copy link
Contributor

@jfonseca-aneo jfonseca-aneo commented Jan 28, 2025

Motivation

PR aneoconsulting/ArmoniK.Core#818 added support to use a tcp socket between the worker and the agent for communication. In this PR we carry out the modifications to be able to use the same feature for the localhost deployment.

Description

Add a new optional parameter socket_type to the compute_plane to specify whether a tcp or a unix socket should be used between the agent and worker.

Testing

Not applicable (tested in Armonik main repository)

Impact

No impact

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants