-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for windows node #173
Open
jdongo-aneo
wants to merge
8
commits into
main
Choose a base branch
from
jd/win-node-pool-aws
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26397ea
to
7448e67
Compare
b0cc1f6
to
37afb23
Compare
monitoring/onpremise/fluent-bit/configs/filter/filter-kubernetes-sidecar.conf
Outdated
Show resolved
Hide resolved
9cd470a
to
434bd8a
Compare
e5a6f7d
to
5f93fbd
Compare
4641028
to
646c1ff
Compare
646c1ff
to
da23e44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the windows daemonset just use the same service account than linux daemonset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having the support for windows nodes in the kubernetes cluster, so that they can be used to perform computation;
Description
We prepare the infrastructure to enable the creation of windows node pools that can be part of the kubernetes cluster.
Testing
We tested the the integration by scheduling control plane and compute plane execution on the windows nodes and been able to collect the logs on cloudwatch.
Impact
Support for hybrid kubernetes cluster creation (linux and windows nodes)
Additional Information
This is only available on AWS for now. GCP support will come later.
Fluent-bit on windows produce errors when using it as a sidecar due to the kube_tag_prefix configuration: fluent/fluent-bit#9142
The way fluent-bit images are managed is not optimal, expecting multi-platform image to come: fluent/fluent-bit#9509
Checklist