Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for windows node #173

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jdongo-aneo
Copy link
Contributor

@jdongo-aneo jdongo-aneo commented Sep 30, 2024

Motivation

Having the support for windows nodes in the kubernetes cluster, so that they can be used to perform computation;

Description

We prepare the infrastructure to enable the creation of windows node pools that can be part of the kubernetes cluster.

Testing

We tested the the integration by scheduling control plane and compute plane execution on the windows nodes and been able to collect the logs on cloudwatch.

Impact

Support for hybrid kubernetes cluster creation (linux and windows nodes)

Additional Information

This is only available on AWS for now. GCP support will come later.
Fluent-bit on windows produce errors when using it as a sidecar due to the kube_tag_prefix configuration: fluent/fluent-bit#9142
The way fluent-bit images are managed is not optimal, expecting multi-platform image to come: fluent/fluent-bit#9509

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@jdongo-aneo jdongo-aneo force-pushed the jd/win-node-pool-aws branch 2 times, most recently from b0cc1f6 to 37afb23 Compare November 27, 2024 15:32
@jdongo-aneo jdongo-aneo marked this pull request as ready for review November 27, 2024 15:44
@jdongo-aneo jdongo-aneo force-pushed the jd/win-node-pool-aws branch 2 times, most recently from 9cd470a to 434bd8a Compare December 5, 2024 13:55
@jdongo-aneo jdongo-aneo force-pushed the jd/win-node-pool-aws branch 2 times, most recently from e5a6f7d to 5f93fbd Compare December 5, 2024 14:29
@jdongo-aneo jdongo-aneo force-pushed the jd/win-node-pool-aws branch 2 times, most recently from 4641028 to 646c1ff Compare December 30, 2024 11:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the windows daemonset just use the same service account than linux daemonset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants