Skip to content

refactor: Remove usage of gRPC defined SessionStatus in internal inte… #1100

refactor: Remove usage of gRPC defined SessionStatus in internal inte…

refactor: Remove usage of gRPC defined SessionStatus in internal inte… #1100

GitHub Actions / Test - windows Adaptors/Memory/tests failed Sep 28, 2023 in 1s

Test - windows Adaptors/Memory/tests ❌

Tests failed

❌ Adaptors/Memory/tests/TestResults/test-results.trx

128 tests were completed in 12s with 127 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ArmoniK.Core.Adapters.Memory.Tests.ResultTableTests 27✅ 2s
ArmoniK.Core.Adapters.Memory.Tests.SessionTableTests 17✅ 1❌ 2s
ArmoniK.Core.Adapters.Memory.Tests.TaskTableTests 83✅ 510ms

✅ ArmoniK.Core.Adapters.Memory.Tests.ResultTableTests

✅ AbortResultsShouldFail
✅ AbortResultsShouldSucceed
✅ AddDependentNotExistingResultShouldThrow
✅ AddDependentShouldSucceed
✅ ChangeResultOwnershipShouldSucceed
✅ CompleteResultShouldSucceed
✅ CompleteResultShouldThrow
✅ CreateShouldFail
✅ CreateShouldSucceed
✅ DeleteResultShouldRemoveOne
✅ DeleteResultsShouldRemoveAll
✅ DeleteUnknownResultShouldFail
✅ GetDependentsShouldSucceed
✅ GetDependentsShouldThrow
✅ GetEmptyDependentsShouldSucceed
✅ GetNotExistingResultStatusShouldSucceed
✅ GetResultBench
✅ GetResultsBench
✅ GetResultStatusShouldSucceed
✅ InitShouldSucceed
✅ ListResultsAsyncFilterResultStatusAndSessionIdLimit1ShouldSucceed
✅ ListResultsAsyncFilterResultStatusAndSessionIdShouldSucceed
✅ ListSessionAsyncNoFilterShouldSucceed
✅ SetResultShouldSucceed
✅ SetResultSmallPayloadShouldSucceed
✅ SetTaskOwnershipShouldFail
✅ SetTaskOwnershipShouldSucceed

❌ ArmoniK.Core.Adapters.Memory.Tests.SessionTableTests

✅ CancelCancelledSessionAsyncShouldFail
✅ CancelSessionAsyncShouldFail
❌ CancelSessionAsyncShouldSucceed
	  Expected: Cancelled (V1.SessionStatus)
	  But was:  Cancelled (Storage.SessionStatus)
	
✅ DeleteSessionAsyncShouldFail
✅ DeleteSessionAsyncShouldSucceed
✅ GetDefaultTaskOptionAsyncShouldFail
✅ GetDefaultTaskOptionAsyncShouldSucceed
✅ InitShouldSucceed
✅ IsSessionCancelledAsyncShouldFail
✅ IsSessionCancelledAsyncShouldSucceed
✅ ListSessionAsyncFilterApplicationNameAndSessionIdShouldSucceed
✅ ListSessionAsyncFilterApplicationNameAndStatusShouldSucceed
✅ ListSessionAsyncFilterApplicationNameShouldSucceed
✅ ListSessionAsyncNoFilterShouldSucceed
✅ ListSessionAsyncShouldFail
✅ ListSessionAsyncShouldSucceed
✅ ListSessionAsyncShouldSucceed2
✅ ListSessionAsyncTaskOptionsOptions

✅ ArmoniK.Core.Adapters.Memory.Tests.TaskTableTests

✅ AcquireAcquiredTaskShouldReturnSame
✅ AcquireCreatingTaskShouldFail
✅ AcquireTaskShouldFail
✅ AcquireTaskShouldSucceed
✅ CancelSessionAsyncShouldSucceed
✅ CancelTasksAsyncEmptyListShouldSucceed
✅ CancelTasksAsyncShouldNotChangeTheGivenStatus(Cancelled)
✅ CancelTasksAsyncShouldNotChangeTheGivenStatus(Cancelling)
✅ CancelTasksAsyncShouldNotChangeTheGivenStatus(Completed)
✅ CancelTasksAsyncShouldNotChangeTheGivenStatus(Error)
✅ CancelTasksShouldSucceed
✅ CountAllTasksAsyncShouldSucceed
✅ CountPartitionTasksAsyncShouldSucceed
✅ CountTasksAsyncShouldSucceed
✅ DeleteTaskShouldFail
✅ DeleteTaskShouldSucceed
✅ FinalizeTaskCreationShouldFail
✅ FinalizeTaskCreationShouldSucceed
✅ FindTasksAsyncContainsShouldSucceed
✅ FindTasksAsyncStatusShouldSucceed(Completed,1)
✅ FindTasksAsyncStatusShouldSucceed(Processing,2)
✅ GetExpectedOutputKeysShouldSucceed
✅ GetParentTaskIdsShouldFail
✅ GetParentTaskIdsShouldSucceed
✅ GetTaskExpectedOutputKeysShouldFail
✅ GetTaskExpectedOutputKeysShouldSucceed
✅ GetTaskOutputShouldFail
✅ GetTaskOutputShouldSucceed
✅ InitShouldSucceed
✅ IsTaskCanceledShouldFail
✅ IsTaskCanceledShouldSucceed
✅ ListApplicationFromTasksShouldSucceed
✅ ListApplicationFromTasksSortShouldSucceed
✅ ListTaskEmptyResultShouldSucceed
✅ ListTaskFilter({ "field": { "taskOptionField": { "field": "TASK_OPTION_ENUM_FIELD_MAX_RETRIES" } }, "filterNumber": { "value": "5", "operator": "FILTER_NUMBER_OPERATOR_LESS_THAN_OR_EQUAL" } } true)
✅ ListTaskFilter({ "field": { "taskOptionField": { "field": "TASK_OPTION_ENUM_FIELD_MAX_RETRIES" } }, "filterNumber": { "value": "5", "operator": "FILTER_NUMBER_OPERATOR_LESS_THAN" } } false)
✅ ListTaskFilter({ "field": { "taskOptionField": { "field": "TASK_OPTION_ENUM_FIELD_PARTITION_ID" } }, "filterString": { "value": "BadPartitionId" } } false)
✅ ListTaskFilter({ "field": { "taskOptionField": { "field": "TASK_OPTION_ENUM_FIELD_PARTITION_ID" } }, "filterString": { "value": "part1" } } true)
✅ ListTaskFilter({ "field": { "taskOptionGenericField": { "field": "key1" } }, "filterString": { "value": "val1" } } true)
✅ ListTaskFilter({ "field": { "taskOptionGenericField": { "field": "key1" } }, "filterString": { "value": "val1", "operator": "FILTER_STRING_OPERATOR_CONTAINS" } } true)
✅ ListTaskFilter({ "field": { "taskOptionGenericField": { "field": "key1" } }, "filterString": { "value": "val1", "operator": "FILTER_STRING_OPERATOR_ENDS_WITH" } } true)
✅ ListTaskFilter({ "field": { "taskOptionGenericField": { "field": "key1" } }, "filterString": { "value": "val1", "operator": "FILTER_STRING_OPERATOR_STARTS_WITH" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_CREATED_AT" } }, "filterDate": { "value": "2020-03-15T00:00:00Z", "operator": "FILTER_DATE_OPERATOR_AFTER_OR_EQUAL" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_CREATED_AT" } }, "filterDate": { "value": "2020-03-15T00:00:00Z", "operator": "FILTER_DATE_OPERATOR_AFTER" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_CREATED_AT" } }, "filterDate": { "value": "2020-03-15T00:00:00Z", "operator": "FILTER_DATE_OPERATOR_BEFORE_OR_EQUAL" } } false)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_CREATED_AT" } }, "filterDate": { "value": "2020-03-15T00:00:00Z", "operator": "FILTER_DATE_OPERATOR_BEFORE" } } false)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "BadSessionId" } } false)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "BadSessionId", "operator": "FILTER_STRING_OPERATOR_NOT_CONTAINS" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "SessionId" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "SessionId", "operator": "FILTER_STRING_OPERATOR_CONTAINS" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "SessionId", "operator": "FILTER_STRING_OPERATOR_ENDS_WITH" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_SESSION_ID" } }, "filterString": { "value": "SessionId", "operator": "FILTER_STRING_OPERATOR_STARTS_WITH" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_STARTED_AT" } }, "filterDate": { } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_STARTED_AT" } }, "filterDate": { } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_STATUS" } }, "filterStatus": { "value": "TASK_STATUS_CANCELLING" } } false)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_STATUS" } }, "filterStatus": { "value": "TASK_STATUS_CANCELLING", "operator": "FILTER_STATUS_OPERATOR_NOT_EQUAL" } } true)
✅ ListTaskFilter({ "field": { "taskSummaryField": { "field": "TASK_SUMMARY_ENUM_FIELD_STATUS" } }, "filterStatus": { "value": "TASK_STATUS_COMPLETED" } } true)
✅ ListTaskShouldSucceed
✅ ListTaskWithListInRequestShouldSucceed
✅ ListTaskWithRequestOrderByTaskOptionsOptionsShouldSucceed
✅ ListTaskWithRequestShouldSucceed
✅ OptionsAreEqual
✅ PayloadIdAfterRetryShouldBeCorrect
✅ ReadTaskAsyncShouldFail
✅ ReadTaskAsyncShouldSucceed
✅ ReleaseTaskShouldSucceed
✅ RemoveRemainingDataDependenciesDepDoesNotExistShouldSucceed
✅ RemoveRemainingDataDependenciesShouldSucceed
✅ RetryTaskShouldSucceed
✅ SetTaskCanceledAsyncShouldSucceed
✅ SetTaskErrorAsyncShouldSucceed
✅ SetTaskSuccessAsyncShouldSucceed
✅ StartTaskInFinalStateShouldThrow(Cancelled)
✅ StartTaskInFinalStateShouldThrow(Completed)
✅ StartTaskInFinalStateShouldThrow(Error)
✅ StartTaskInFinalStateShouldThrow(Retried)
✅ StartTaskShouldFail
✅ StartTaskShouldSucceed
✅ UpdateAllTaskStatusAsyncShouldFailOnSomeStatus(Cancelled)
✅ UpdateAllTaskStatusAsyncShouldFailOnSomeStatus(Completed)
✅ UpdateAllTaskStatusAsyncShouldFailOnSomeStatus(Error)
✅ UpdateAllTaskStatusAsyncShouldSucceed
✅ UpdateAllTaskStatusAsyncShouldSucceedIfNoStatusGiven

Annotations

Check failure on line 233 in Common/tests/TestBase/SessionTableTestBase.cs

See this annotation in the file changed.

@github-actions github-actions / Test - windows Adaptors/Memory/tests

ArmoniK.Core.Adapters.Memory.Tests.SessionTableTests ► CancelSessionAsyncShouldSucceed

Failed test found in:
  Adaptors/Memory/tests/TestResults/test-results.trx
Error:
    Expected: Cancelled (V1.SessionStatus)
    But was:  Cancelled (Storage.SessionStatus)
  
Raw output
  Expected: Cancelled (V1.SessionStatus)
  But was:  Cancelled (Storage.SessionStatus)

   at ArmoniK.Core.Common.Tests.TestBase.SessionTableTestBase.CancelSessionAsyncShouldSucceed() in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\TestBase\SessionTableTestBase.cs:line 233
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.GetResult()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

1)    at ArmoniK.Core.Common.Tests.TestBase.SessionTableTestBase.CancelSessionAsyncShouldSucceed() in D:\a\ArmoniK.Core\ArmoniK.Core\Common\tests\TestBase\SessionTableTestBase.cs:line 233
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at ArmoniK.Core.Common.Tests.TestBase.SessionTableTestBase.CancelSessionAsyncShouldSucceed()