Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Options to disable exactlyOnceDelivery #848

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

lemaitre-aneo
Copy link
Contributor

@lemaitre-aneo lemaitre-aneo commented Feb 13, 2025

Motivation

Pub/Sub has a feature to guarantee that messages are delivered exactly once (no duplication). This feature was enabled by the ArmoniK plugin, but it appears the impact is very high on the throughput of the queue, and is not necessary for the scheduling correctness because ArmoniK is already able to deduplicate messages while acquiring tasks from the queue.

Description

This PR exposes 2 options ExactlyOnceDelivery and MessageOrdering when the plugin creates the subscriptions. Those options are disabled by default.

Testing

[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@lemaitre-aneo lemaitre-aneo merged commit e14387b into main Feb 13, 2025
104 checks passed
@lemaitre-aneo lemaitre-aneo deleted the fl/pubsub-exactly-once-delivery branch February 13, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants