feat: Options to disable exactlyOnceDelivery #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pub/Sub has a feature to guarantee that messages are delivered exactly once (no duplication). This feature was enabled by the ArmoniK plugin, but it appears the impact is very high on the throughput of the queue, and is not necessary for the scheduling correctness because ArmoniK is already able to deduplicate messages while acquiring tasks from the queue.
Description
This PR exposes 2 options ExactlyOnceDelivery and MessageOrdering when the plugin creates the subscriptions. Those options are disabled by default.
Testing
[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]
Impact
[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]
Checklist