Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle default authentication for SQS #809

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix: Handle default authentication for SQS #809

merged 3 commits into from
Dec 13, 2024

Conversation

lemaitre-aneo
Copy link
Contributor

@lemaitre-aneo lemaitre-aneo commented Dec 10, 2024

Motivation

Current SQS implementation requires credentials to be passed in environment variables, and does not support aws config file or pod service account on kubernetes.

Description

Use the package AWSSDK.SecurityToken to handle the default authentication for AWS services, as it's currently done for S3 Adapter.

Testing

Test has been done locally with localstack, as well as on AWS with an actual SQS, and bindings between Kubernetes service account and IAM role.

Impact

When both S3 and SQS is configured to use the IAM roles through Kubernetes service account, there is a loading issue for the AWSSDK.SecurityToken assembly while creating a SQS client.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

aneojgurhem
aneojgurhem previously approved these changes Dec 12, 2024
@lemaitre-aneo lemaitre-aneo marked this pull request as ready for review December 13, 2024 08:53
@lemaitre-aneo lemaitre-aneo merged commit 2e88e40 into main Dec 13, 2024
100 checks passed
@lemaitre-aneo lemaitre-aneo deleted the fl/sqs-auth branch December 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants