Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to resume a running session #802

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: allow to resume a running session #802

merged 1 commit into from
Nov 27, 2024

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Nov 26, 2024

Motivation

Allow a running session to be resumed. It also allows to retry Resume RPC when errors occur. Does not put tasks back in Paused status when an error occur.

Description

  • Remove the call to change the task status back to paused when there is an exception.
  • Allow session status change to Running when the session is already Running

Testing

  • Tests were performed with the GUI on the ArmoniK infrastructure. It fixes the issue when the Resume RPC times out. The tasks are not put back in Paused.

Impact

  • Resume is working more reliably.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@aneojgurhem aneojgurhem merged commit 2e55acc into main Nov 27, 2024
95 checks passed
@aneojgurhem aneojgurhem deleted the jg/fixresume branch November 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants