Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pull windows client image in a separate step #796

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Nov 14, 2024

Motivation

Separate pull and run of windows image to improve workflows success rate.

Description

This PR modifies the CI to pull bench windows image before running them to let more time to download the image than the run of it.

Testing

Windows workflow now succeed.

Impact

Improve windows workflow success rate.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@aneojgurhem aneojgurhem merged commit aa0d9f3 into main Nov 14, 2024
95 checks passed
@aneojgurhem aneojgurhem deleted the jg/pullwindows branch November 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants