Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add debug logs around message push into the queue storage #791

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

aneojgurhem
Copy link
Contributor

@aneojgurhem aneojgurhem commented Nov 4, 2024

Motivation

Add debug logs to confirm messages inserted into the queue storage.

Description

Add two logs in TaskLifeCycleHelper:

  • messages that are created by a tasks
  • messages pushed into the queue

They can be activated by the following env vars:

  • Serilog__MinimumLevel__Override__ArmoniK.Core.Common.Pollster.TaskHandler=Debug
  • Serilog__MinimumLevel__Override__ArmoniK.Core.Common.gRPC.Services.Submitter=Debug

Testing

Logs appear in Seq while deploying locally.

Impact

In Debug mode for the logger, the log volume will increase due to the addititon of new logs.

Additional Information

Submitter will need to be removed in order to refactor logger contexts used in TaskLifeCycleHelper so that logs appear either in their context or within the caller context.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

lemaitre-aneo
lemaitre-aneo previously approved these changes Nov 4, 2024
Common/src/Storage/TaskLifeCycleHelper.cs Outdated Show resolved Hide resolved
Common/src/Storage/TaskLifeCycleHelper.cs Outdated Show resolved Hide resolved
@aneojgurhem aneojgurhem merged commit abf9864 into main Nov 4, 2024
95 checks passed
@aneojgurhem aneojgurhem deleted the jg/logs branch November 4, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants