feat: build windows images #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aneojgurhem
commented
Jun 11, 2024
•
aneojgurhem
commented
- Windows Image Build
- Dockerfile
- Unified dockerfile
- Update Entrypoint so that images execute properly
- Core infra
- justfile windows compatible
- toogle services that do not have windows images
- fix mount points to make them compatible with Windows
- deploy rabbitmq with windows docker image
aneojgurhem
force-pushed
the
jg/winimages
branch
22 times, most recently
from
e0106e4 to
429d68c
Compare
aneojgurhem
force-pushed
the
jg/winimages
branch
8 times, most recently
from
e189e24 to
81fe0e5
Compare
aneojgurhem
force-pushed
the
jg/winimages
branch
from
81fe0e5 to
f16d665
Compare
aneojgurhem
force-pushed
the
jg/winimages
branch
2 times, most recently
from
b9e1286 to
0937280
Compare
aneojgurhem
force-pushed
the
jg/winimages
branch
from
0937280 to
566704a
Compare
ngruelaneo
previously approved these changes
Aug 12, 2024
aneojgurhem
force-pushed
the
jg/winimages
branch
from
27fbacd to
5054a01
Compare
Comment on lines
-83
to
-89
| healthcheck { | ||
| test = ["CMD", "bash", "-c", "exec 3<>\"/dev/tcp/localhost/1080\" && echo -en \"GET /liveness HTTP/1.1\r\nHost: localhost:1080\r\nConnection: close\r\n\r\n\">&3 && grep Healthy <&3 &>/dev/null || exit 1"] | ||
| interval = "5s" | ||
| timeout = "3s" | ||
| start_period = "20s" | ||
| retries = 5 | ||
| } |
There was a problem hiding this comment.
Don't you want to keep it on Linux?
There was a problem hiding this comment.
I did not want to introduce new variable and container crashes and restarts with the current implementation
aneojgurhem
force-pushed
the
jg/winimages
branch
from
21342aa to
ee47809
Compare
lemaitre-aneo
previously approved these changes
Aug 20, 2024
Co-authored-by: lemaitre-aneo <[email protected]>
lemaitre-aneo
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.