refactor: only compute throughput for htcmock and bench #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
requested review from
ngruelaneo,
lemaitre-aneo and
qdelamea-aneo
| @@ -428,4 +467,81 @@ await foreach (var resp in streamingCall.ResponseStream.ReadAllAsync(cancellatio | |||
| } | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| public static async Task<long> ComputeThroughput(this ChannelBase channel, | |||
There was a problem hiding this comment.
Seemed a good idea. What do you suggest ?
Comment on lines
539
to
545
| logger.LogInformation("Throughput for session {session} : {sessionThroughput} task/s ({nTasks} tasks in {timespan})", | ||
| sessionId, | ||
| count / sessionDuration.TotalMilliseconds * 1000, | ||
| count, | ||
| sessionDuration); | ||
|
|
||
| return (long)(sessionDuration.TotalMilliseconds * 1000 / count); |
There was a problem hiding this comment.
If you print the throughtput in this function, it can return void.
There was a problem hiding this comment.
I thought that if someone need to present the data in another way, it would be good to return the info.
There was a problem hiding this comment.
Then, I would recommend to put the logs outside
lemaitre-aneo
previously approved these changes
Feb 12, 2024
| @@ -428,4 +467,81 @@ await foreach (var resp in streamingCall.ResponseStream.ReadAllAsync(cancellatio | |||
| } | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| public static async Task<long> ComputeThroughput(this ChannelBase channel, | |||
Comment on lines
539
to
545
| logger.LogInformation("Throughput for session {session} : {sessionThroughput} task/s ({nTasks} tasks in {timespan})", | ||
| sessionId, | ||
| count / sessionDuration.TotalMilliseconds * 1000, | ||
| count, | ||
| sessionDuration); | ||
|
|
||
| return (long)(sessionDuration.TotalMilliseconds * 1000 / count); |
There was a problem hiding this comment.
Then, I would recommend to put the logs outside
lemaitre-aneo
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.