Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: close submission in session #622

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: close submission in session #622

merged 2 commits into from
Feb 8, 2024

Conversation

aneojgurhem
Copy link
Contributor

No description provided.

ngruelaneo
ngruelaneo previously approved these changes Feb 7, 2024
Copy link
Contributor

@lemaitre-aneo lemaitre-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to catch SubmissionClosed and transform it in RpcException only in TaskService, but not in AgentService?

Common/src/Exceptions/SubmissionClosed.cs Outdated Show resolved Hide resolved
holder.Token,
NullLogger.Instance);

Assert.ThrowsAsync<SubmissionClosed>(() => agent.SubmitTasks(new TaskSubmissionRequest[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.That ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it with the others!

@aneojgurhem aneojgurhem merged commit d04f5c6 into main Feb 8, 2024
78 checks passed
@aneojgurhem aneojgurhem deleted the jg/closesub branch February 8, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants