refactor: use cache for push in AMQP plugin #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
requested review from
ngruelaneo,
lemaitre-aneo and
qdelamea-aneo
aneojgurhem
force-pushed
the
jg/pushcache
branch
from
7c859ae to
33fbecc
Compare
lemaitre-aneo
previously approved these changes
Feb 5, 2024
|
|
||
| var pool = senders_.GetOrAdd(address, | ||
| s => new ObjectPool<SenderLink>(parallelismLimit_, | ||
| async token => new SenderLink(new Session(await ConnectionAmqp |
There was a problem hiding this comment.
So each Link have its own Session. Is it something we want to keep?
| _) => new ValueTask<bool>(!link.IsClosed && | ||
| !link.Session.IsClosed))); | ||
|
|
||
| await pool.WithInstanceAsync(sender => sender.SendAsync(new Message(Encoding.UTF8.GetBytes(msgData.TaskId)) |
There was a problem hiding this comment.
You did not pass the cancellation token to SendAsync.
There was a problem hiding this comment.
It does not take cancellation tokens
lemaitre-aneo
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.