Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recreate AMQP connection when dropped #605

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Conversation

aneojgurhem
Copy link
Contributor

No description provided.

Adaptors/Amqp/src/ConnectionAmqp.cs Outdated Show resolved Hide resolved
Adaptors/Amqp/src/ConnectionAmqp.cs Outdated Show resolved Hide resolved
lemaitre-aneo
lemaitre-aneo previously approved these changes Jan 31, 2024

private static async Task InitTask(ConnectionAmqp conn,
CancellationToken cancellationToken = default)
public async Task<Connection> GetConnectionAsync(CancellationToken cancellationToken = default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove "async" if you return the Task from the ExecutionSingleizer directly.

private readonly ILogger<ConnectionAmqp> logger_;
private readonly QueueCommon.Amqp options_;
private bool isInitialized_;
private readonly ExecutionSingleizer<Connection> connectionSingleizer_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private readonly ExecutionSingleizer<Connection> connectionSingleizer_;
private readonly ExecutionSingleizer<Connection> connectionSingleizer_ = new();

@aneojgurhem aneojgurhem merged commit c496f7c into main Jan 31, 2024
73 checks passed
@aneojgurhem aneojgurhem deleted the jg/connectionamqp branch January 31, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants