refactor: remove gRPC objects from IAgent #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aneojgurhem
commented
Jan 22, 2024
•
aneojgurhem
commented
- refactor: remove gRPC objects from IAgent NotifyResultData
- refactor: remove gRPC objects from IAgent CreateResultsMetaData
- refactor: remove gRPC objects from IAgent CreateResults
aneojgurhem
requested review from
ngruelaneo,
lemaitre-aneo and
qdelamea-aneo
| @@ -123,17 +125,14 @@ public Task Stop() | |||
| }; | |||
| } | |||
|
|
|||
| var result = (await agent_.CreateResultsMetaData(new CreateResultsMetaDataRequest | |||
| var result = (await agent_.CreateResultsMetaData(agent_.Token, | |||
| new List<ResultCreationRequest> | |||
There was a problem hiding this comment.
Suggested change
| new List<ResultCreationRequest> | |
| new ResultCreationRequest[] |
Common/tests/Helpers/SimpleAgent.cs
Outdated
| public Task<ICollection<Result>> CreateResultsMetaData(string token, | ||
| ICollection<ResultCreationRequest> requests, | ||
| CancellationToken cancellationToken) | ||
| => Task.FromResult(new List<Result>().AsICollection()); |
There was a problem hiding this comment.
Suggested change
| => Task.FromResult(new List<Result>().AsICollection()); | |
| => Task.FromResult(Array.Empty<Result>().AsICollection()); |
Common/tests/Helpers/SimpleAgent.cs
Outdated
| @@ -70,21 +68,21 @@ public Task FinalizeTaskCreation(CancellationToken cancellationToken) | |||
| CancellationToken cancellationToken) | |||
| => Task.FromResult(new List<TaskCreationRequest>().AsICollection()); | |||
There was a problem hiding this comment.
Suggested change
| => Task.FromResult(new List<TaskCreationRequest>().AsICollection()); | |
| => Task.FromResult(Array.Empty<TaskCreationRequest>().AsICollection()); |
Common/tests/Pollster/AgentTest.cs
Outdated
| CommunicationToken = token, | ||
| }, | ||
| Assert.ThrowsAsync<RpcException>(() => holder.Agent.CreateResultsMetaData(token, | ||
| new List<ResultCreationRequest>(), |
There was a problem hiding this comment.
Suggested change
| new List<ResultCreationRequest>(), | |
| Array.Empty<ResultCreationRequest>(), |
Common/tests/Pollster/AgentTest.cs
Outdated
| @@ -746,52 +684,34 @@ public async Task SubmitTasksCreateOneRequestShouldSucceed(bool optionsNull) | |||
| { | |||
| using var holder = new AgentHolder(); | |||
|
|
|||
| var payload = await holder.Agent.CreateResults(new CreateResultsRequest | |||
| var payload = await holder.Agent.CreateResults(holder.Token, | |||
| new List<(ResultCreationRequest request, ReadOnlyMemory<byte> data)> | |||
There was a problem hiding this comment.
Suggested change
| new List<(ResultCreationRequest request, ReadOnlyMemory<byte> data)> | |
| new (ResultCreationRequest request, ReadOnlyMemory<byte> data)[] |
Common/tests/Pollster/AgentTest.cs
Outdated
| }, | ||
| CancellationToken.None) | ||
| .ConfigureAwait(false); | ||
|
|
||
| var eok = await holder.Agent.CreateResultsMetaData(new CreateResultsMetaDataRequest | ||
| var eok = await holder.Agent.CreateResultsMetaData(holder.Token, | ||
| new List<ResultCreationRequest> |
There was a problem hiding this comment.
Suggested change
| new List<ResultCreationRequest> | |
| new ResultCreationRequest[] |
Comment on lines
+714
to
715
| eok.Select(r => r.ResultId) | ||
| .AsICollection(), |
There was a problem hiding this comment.
Suggested change
| eok.Select(r => r.ResultId) | |
| .AsICollection(), | |
| eok.ViewSelect(r => r.ResultId), |
Common/tests/Pollster/AgentTest.cs
Outdated
| @@ -837,37 +757,27 @@ public async Task SubmitTasksUploadPayloadShouldSucceed(bool optionsNull) | |||
| { | |||
| using var holder = new AgentHolder(); | |||
|
|
|||
| var eok = await holder.Agent.CreateResultsMetaData(new CreateResultsMetaDataRequest | |||
| var eok = await holder.Agent.CreateResultsMetaData(holder.Token, | |||
| new List<ResultCreationRequest> | |||
There was a problem hiding this comment.
Suggested change
| new List<ResultCreationRequest> | |
| new ResultCreationRequest[] |
lemaitre-aneo
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.