perf: improve wait for results performances by reducing the size of the request and making multiple at the same time #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
dbrasseur-aneo
requested changes
Aug 20, 2024
Comment on lines
+116
to
+177
| while (await streamingCall.ResponseStream.MoveNext(cancellationToken)) | ||
| { | ||
| var resp = streamingCall.ResponseStream.Current; | ||
| if (resp.UpdateCase == EventSubscriptionResponse.UpdateOneofCase.ResultStatusUpdate && | ||
| resultsNotFound.Contains(resp.ResultStatusUpdate.ResultId)) | ||
| { | ||
| if (resp.ResultStatusUpdate.Status == ResultStatus.Completed) | ||
| { | ||
| SessionId = sessionId, | ||
| ReturnedEvents = | ||
| resultsNotFound.Remove(resp.ResultStatusUpdate.ResultId); | ||
| if (!resultsNotFound.Any()) | ||
| { | ||
| EventsEnum.ResultStatusUpdate, | ||
| EventsEnum.NewResult, | ||
| }, | ||
| ResultsFilters = new Filters | ||
| { | ||
| Or = | ||
| { | ||
| resultsNotFound.Select(ResultsFilter), | ||
| }, | ||
| }, | ||
| }, | ||
| cancellationToken: cancellationToken); | ||
| try | ||
| { | ||
| while (await streamingCall.ResponseStream.MoveNext(cancellationToken)) | ||
| { | ||
| var resp = streamingCall.ResponseStream.Current; | ||
| if (resp.UpdateCase == EventSubscriptionResponse.UpdateOneofCase.ResultStatusUpdate && resultsNotFound.Contains(resp.ResultStatusUpdate.ResultId)) | ||
| { | ||
| if (resp.ResultStatusUpdate.Status == ResultStatus.Completed) | ||
| { | ||
| resultsNotFound.Remove(resp.ResultStatusUpdate.ResultId); | ||
| if (!resultsNotFound.Any()) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (resp.ResultStatusUpdate.Status == ResultStatus.Aborted) | ||
| { | ||
| throw new ResultAbortedException($"Result {resp.ResultStatusUpdate.ResultId} has been aborted"); | ||
| } | ||
| } | ||
| if (resp.ResultStatusUpdate.Status == ResultStatus.Aborted) | ||
| { | ||
| throw new ResultAbortedException($"Result {resp.ResultStatusUpdate.ResultId} has been aborted"); | ||
| } | ||
| } | ||
|
|
||
| if (resp.UpdateCase == EventSubscriptionResponse.UpdateOneofCase.NewResult && resultsNotFound.Contains(resp.NewResult.ResultId)) | ||
| { | ||
| if (resp.NewResult.Status == ResultStatus.Completed) | ||
| { | ||
| resultsNotFound.Remove(resp.NewResult.ResultId); | ||
| if (!resultsNotFound.Any()) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
| if (resp.UpdateCase == EventSubscriptionResponse.UpdateOneofCase.NewResult && | ||
| resultsNotFound.Contains(resp.NewResult.ResultId)) | ||
| { | ||
| if (resp.NewResult.Status == ResultStatus.Completed) | ||
| { | ||
| resultsNotFound.Remove(resp.NewResult.ResultId); | ||
| if (!resultsNotFound.Any()) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (resp.NewResult.Status == ResultStatus.Aborted) | ||
| { | ||
| throw new ResultAbortedException($"Result {resp.NewResult.ResultId} has been aborted"); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| catch (OperationCanceledException) | ||
| { | ||
| } | ||
| catch (RpcException) | ||
| { | ||
| } | ||
| } | ||
| } | ||
| if (resp.NewResult.Status == ResultStatus.Aborted) | ||
| { | ||
| throw new ResultAbortedException($"Result {resp.NewResult.ResultId} has been aborted"); | ||
| } | ||
| } |
There was a problem hiding this comment.
You can handle both cases without repetition by extracting the "status" and "resultId" first depending on the event type, then do the checks and throw if necessary
…he request and making multiple at the same time
dbrasseur-aneo
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.