Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Abort immediately upon cancellation #495

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

lemaitre-aneo
Copy link
Contributor

Change the default option and abort immediately upon cancellation.

This is to limit the edge case that a task cancellation that is not catched would make the next task to crash and being retried.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1158 915 79% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 6a5128a by action🐍

@lemaitre-aneo
Copy link
Contributor Author

The proper fix would be to add a rpc that the worker would call to inform the agent that the call has actually been cancelled.

@lemaitre-aneo lemaitre-aneo merged commit 3c8b103 into main Apr 18, 2024
25 of 32 checks passed
@lemaitre-aneo lemaitre-aneo deleted the fl/abort-zero branch April 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants