-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Python API: support upload decoupling #447
base: main
Are you sure you want to change the base?
Conversation
qdelamea-aneo
commented
Dec 20, 2023
- Python API update Task and Result service
- Python API update Results Tasks Events Partitions and Versions services
- Python API update task handler
page=page, | ||
page_size=page_size, | ||
filters=cast(rawFilters, task_filter.to_disjunction().to_message()), | ||
filters=cast(rawFilters, session_filter.to_disjunction().to_message()), | ||
sort=ListSessionsRequest.Sort(field=cast(SessionField, sort_field.field), direction=sort_direction), | ||
) | ||
list_response : ListSessionsResponse = self._client.ListSessions(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you remove the type line 79 and keep it here?
bc536b3
to
f89b0ac
Compare
1e9d971
to
cbea272
Compare
@@ -33,7 +33,7 @@ python -m pip install --upgrade pip | |||
python -m venv $PYTHON_VENV | |||
source $PYTHON_VENV/bin/activate | |||
# We need to fix grpc to 1.56 until this bug is solved : https://github.com/grpc/grpc/issues/34305 | |||
python -m pip install build grpcio==1.56.2 grpcio-tools==1.56.2 click pytest setuptools_scm[toml] | |||
python -m pip install build grpcio==1.56.2 grpcio-tools==1.56.2 click pytest setuptools_scm[toml] ruff requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest, setuptool_scm, ruff and requests should not be here but in the pyproject.toml file
@@ -0,0 +1,21 @@ | |||
from typing import cast, List, Tuple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
.github/workflows/ci.yml
Outdated
run: | | ||
cd ../csharp/ArmoniK.Api.Mock | ||
nohup dotnet run > /dev/null 2>&1 & | ||
sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some chance that you have to increase the waiting time for the service to be started. On my wsl, it take at least 20 seconds to start completely. The vm provided by github are not very veloce either.