feat: C++14 support and various installation fixes #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dbrasseur-aneo
commented
Sep 13, 2023
•
dbrasseur-aneo
commented
- Option to change url of dependencies
- Cpp14 support
- Explicit namespaces
- Fix protobuf package issue on windows
dbrasseur-aneo
force-pushed
the
db/installationIssues
branch
from
bbe4465 to
8a3b3ad
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
dbrasseur-aneo
changed the title
dbrasseur-aneo
requested review from
lemaitre-aneo,
ddiakiteaneo and
ddubuc
ddiakiteaneo
changed the title
lemaitre-aneo
previously approved these changes
Sep 14, 2023
packages/cpp/ArmoniK.Api.Client/source/submitter/ResultsClient.cpp
Outdated
Show resolved
Hide resolved
packages/cpp/ArmoniK.Api.Client/header/submitter/SubmitterClient.h
Outdated
Show resolved
Hide resolved
packages/cpp/ArmoniK.Api.Client/source/submitter/ResultsClient.cpp
Outdated
Show resolved
Hide resolved
packages/cpp/ArmoniK.Api.Client/source/submitter/ResultsClient.cpp
Outdated
Show resolved
Hide resolved
ddiakiteaneo
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.