Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows to create sessions in sessions service #384

Merged
merged 1 commit into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Protos/V1/sessions_common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,20 @@ message CancelSessionRequest {
message CancelSessionResponse {
SessionRaw session = 1; /** The session. */
}

/**
* Request for creating session.
*/
message CreateSessionRequest {
TaskOptions default_task_option = 1; /** Default tasks options for tasks in the session */
repeated string partition_ids = 2; /** List of partitions allowed during the session */
}

/*
Reply after session creation.
We have this reply in case of success.
When the session creation is not successful, there is an rpc exception.
*/
message CreateSessionReply {
string session_id = 1; /** Session id of the created session if successful */
}
5 changes: 5 additions & 0 deletions Protos/V1/sessions_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,9 @@ service Sessions {
* Cancel a session by its id.
*/
rpc CancelSession(CancelSessionRequest) returns (CancelSessionResponse) {}

/**
* Create a session
*/
rpc CreateSession(CreateSessionRequest) returns (CreateSessionReply);
}