fix: various fixes #362
Merged
fix: various fixes #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace uniformity Fixed submitter get result not giving proper error Added ArmoniK specific exceptions Fix worker unable to send result Fix worker unable to send tasks Fix worker creation Fix jsonconfig not allowed to fail byte arrays are now string (for ease with grpc) added warnings for compilation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
ddiakiteaneo
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace uniformity
Fixed submitter get result not giving proper error Added ArmoniK specific exceptions
Fix worker unable to send result
Fix worker unable to send tasks
Fix worker creation
Fix jsonconfig not allowed to fail
byte arrays are now string (for ease with grpc)
added warnings for compilation